diff options
author | tnut <thierryn1 at hispeed dot ch> | 2010-10-22 16:36:18 +0200 |
---|---|---|
committer | tnut <thierryn1 at hispeed dot ch> | 2010-10-22 16:36:18 +0200 |
commit | ba3004119ddfedb9102716b9d82cacfaa7f7773b (patch) | |
tree | ab376716253dcdf6cc5806171f51b0402fa524cf /kde/amarok/scanning-qt-regression.patch | |
parent | 26695044ff5ddbd5825858f4e157c1dcb67cc859 (diff) | |
download | nutyx-pakxe-ba3004119ddfedb9102716b9d82cacfaa7f7773b.tar.gz nutyx-pakxe-ba3004119ddfedb9102716b9d82cacfaa7f7773b.tar.bz2 nutyx-pakxe-ba3004119ddfedb9102716b9d82cacfaa7f7773b.tar.xz nutyx-pakxe-ba3004119ddfedb9102716b9d82cacfaa7f7773b.zip |
amarok, port nettoyé
Diffstat (limited to 'kde/amarok/scanning-qt-regression.patch')
-rw-r--r-- | kde/amarok/scanning-qt-regression.patch | 80 |
1 files changed, 0 insertions, 80 deletions
diff --git a/kde/amarok/scanning-qt-regression.patch b/kde/amarok/scanning-qt-regression.patch deleted file mode 100644 index 27c6bb067..000000000 --- a/kde/amarok/scanning-qt-regression.patch +++ /dev/null @@ -1,80 +0,0 @@ -From: Jeff Mitchell <mitchell@kde.org> -Date: Wed, 22 Sep 2010 22:15:17 +0000 (-0400) -Subject: Re-add some tests for unprintable but also invalid chars. Apparently Qt's XML classes... -X-Git-Url: http://gitweb.kde.org?hp=fd2a40d970c57fa2102e95de1a60c59e37892638 - -Re-add some tests for unprintable but also invalid chars. Apparently Qt's XML classes don't properly check for invalid chars when writing XML, even if you tell them to. - -Also switch to QXmlStreamWriter, as apparently going forward it is the more supported class. - -BUG: 251762 ---- - -diff --git a/utilities/collectionscanner/CollectionScanner.cpp b/utilities/collectionscanner/CollectionScanner.cpp -index 0a23a53..28c554b 100644 ---- a/utilities/collectionscanner/CollectionScanner.cpp -+++ b/utilities/collectionscanner/CollectionScanner.cpp -@@ -37,13 +37,13 @@ - #include <QByteArray> - #include <QDBusReply> - #include <QDir> --#include <QDomDocument> - #include <QFile> - #include <QtDebug> - #include <QTextCodec> - #include <QTextStream> - #include <QTimer> - #include <QThread> -+#include <QXmlStreamWriter> - - //Taglib: - #include <apetag.h> -@@ -814,8 +814,10 @@ CollectionScanner::readTags( const QString &path, TagLib::AudioProperties::ReadS - void - CollectionScanner::writeElement( const QString &name, const AttributeHash &attributes ) - { -- QDomDocument doc; // A dummy. We don't really use DOM, but SAX2 -- QDomElement element = doc.createElement( name ); -+ QString text; -+ QXmlStreamWriter writer( &text ); -+ -+ writer.writeStartElement( name ); - - QHashIterator<QString, QString> it( attributes ); - while( it.hasNext() ) -@@ -829,7 +831,15 @@ CollectionScanner::writeElement( const QString &name, const AttributeHash &attri - bool noCategory = false; - for( unsigned i = 0; i < len; i++ ) - { -- if( data[i].category() == QChar::NoCategory ) -+ if( data[i].category() == QChar::NoCategory || -+ data[i].category() == QChar::Other_Surrogate || -+ ( -+ data[i].unicode() < 20 && -+ data[i].unicode() != 9 && -+ data[i].unicode() != 10 && -+ data[i].unicode() != 13 -+ ) -+ ) - { - noCategory = true; - break; -@@ -838,15 +848,12 @@ CollectionScanner::writeElement( const QString &name, const AttributeHash &attri - - if( noCategory ) - continue; -- -- element.setAttribute( it.key(), it.value() ); -+ writer.writeAttribute( it.key(), it.value() ); - } - -- QString text; -- QTextStream stream( &text, QIODevice::WriteOnly ); -- element.save( stream, 0 ); -+ writer.writeEndElement(); - -- std::cout << text.toUtf8().data() << std::endl; -+ std::cout << text.toUtf8().data() << std::endl << std::endl; - } - - // taken verbatim from Qt's sources, since it's stupidly in the QtGui module |